Changeset 631

Show
Ignore:
Timestamp:
01/06/09 13:12:05
Author:
rachel
Message:

Use OPS_ARMOURED/UNARMOURED where possible

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • openpgpsdk/trunk/tests/test_common.c

    r630 r631  
    195195    assert(alphadsa_skey); 
    196196    assert(bravodsa_pkey); 
    197     assert(bravodsa_skey); //not yet set because of passphrase 
     197    assert(bravodsa_skey);  
    198198} 
    199199 
  • openpgpsdk/trunk/tests/test_dsa_signature.c

    r629 r631  
    2323 
    2424#include <openpgpsdk/types.h> 
     25#include <openpgpsdk/defs.h> 
    2526#include "openpgpsdk/keyring.h" 
    2627#include <openpgpsdk/armour.h> 
     
    425426static void test_dsa_signature_large_noarmour_nopassphrase(void) 
    426427    { 
    427     int armour=0; 
    428     assert(pub_keyring.nkeys); 
    429     test_dsa_signature_sign(armour,filename_dsa_large_noarmour_nopassphrase, alphadsa_skey); 
     428    assert(pub_keyring.nkeys); 
     429    test_dsa_signature_sign(OPS_UNARMOURED,filename_dsa_large_noarmour_nopassphrase, alphadsa_skey); 
    430430    } 
    431431 
    432432static void test_dsa_signature_large_armour_nopassphrase(void) 
    433433    { 
    434     int armour=1; 
    435     assert(pub_keyring.nkeys); 
    436     test_dsa_signature_sign(armour,filename_dsa_large_armour_nopassphrase, alphadsa_skey); 
     434    assert(pub_keyring.nkeys); 
     435    test_dsa_signature_sign(OPS_ARMOURED,filename_dsa_large_armour_nopassphrase, alphadsa_skey); 
    437436    } 
    438437 
     
    440439    { 
    441440    unsigned char testdata[MAXBUF]; 
    442     int armour=0; 
    443441    assert(pub_keyring.nkeys); 
    444442    assert(alphadsa_skey); 
    445     test_dsa_signature_sign(armour,filename_dsa_noarmour_nopassphrase, alphadsa_skey); 
     443    test_dsa_signature_sign(OPS_UNARMOURED,filename_dsa_noarmour_nopassphrase, alphadsa_skey); 
    446444    create_testdata("test_dsa_signature_noarmour_nopassphrase",testdata, MAXBUF); 
    447     test_dsa_signature_sign_memory(armour,testdata,MAXBUF, alphadsa_skey); 
     445    test_dsa_signature_sign_memory(OPS_UNARMOURED,testdata,MAXBUF, alphadsa_skey); 
    448446    } 
    449447 
     
    451449    { 
    452450    unsigned char testdata[MAXBUF]; 
    453     int armour=0; 
    454     assert(pub_keyring.nkeys); 
    455     test_dsa_signature_sign(armour,filename_dsa_noarmour_passphrase, bravodsa_skey); 
     451    assert(pub_keyring.nkeys); 
     452    test_dsa_signature_sign(OPS_UNARMOURED,filename_dsa_noarmour_passphrase, bravodsa_skey); 
    456453 
    457454    create_testdata("test_dsa_signature_noarmour_passphrase",testdata, MAXBUF); 
    458     test_dsa_signature_sign_memory(armour,testdata,MAXBUF, bravodsa_skey); 
     455    test_dsa_signature_sign_memory(OPS_UNARMOURED,testdata,MAXBUF, bravodsa_skey); 
    459456    } 
    460457 
     
    462459    { 
    463460    unsigned char testdata[MAXBUF]; 
    464     int armour=1; 
    465     assert(pub_keyring.nkeys); 
    466     test_dsa_signature_sign(armour,filename_dsa_armour_nopassphrase, alphadsa_skey); 
     461    assert(pub_keyring.nkeys); 
     462    test_dsa_signature_sign(OPS_ARMOURED,filename_dsa_armour_nopassphrase, alphadsa_skey); 
    467463 
    468464    create_testdata("test_dsa_signature_armour_nopassphrase",testdata, MAXBUF); 
    469     test_dsa_signature_sign_memory(armour,testdata,MAXBUF, alphadsa_skey); 
     465    test_dsa_signature_sign_memory(OPS_UNARMOURED,testdata,MAXBUF, alphadsa_skey); 
    470466    } 
    471467 
     
    474470    unsigned char testdata[MAXBUF]; 
    475471 
    476     int armour=1; 
    477     assert(pub_keyring.nkeys); 
    478     test_dsa_signature_sign(armour,filename_dsa_armour_passphrase, bravodsa_skey); 
     472    assert(pub_keyring.nkeys); 
     473    test_dsa_signature_sign(OPS_ARMOURED,filename_dsa_armour_passphrase, bravodsa_skey); 
    479474 
    480475    create_testdata("test_dsa_signature_armour_passphrase",testdata, MAXBUF); 
    481     test_dsa_signature_sign_memory(armour,testdata,MAXBUF, bravodsa_skey); 
     476    test_dsa_signature_sign_memory(OPS_ARMOURED,testdata,MAXBUF, bravodsa_skey); 
    482477    } 
    483478 
     
    504499    assert(pub_keyring.nkeys); 
    505500    test_dsa_signature_clearsign_buf(filename_dsa_clearsign_buf_passphrase, bravodsa_skey); 
     501    } 
     502 
     503static void test_dsa_signature_dss(void) 
     504    { 
     505    unsigned char testdata[MAXBUF]; 
     506    assert(sec_keyring.nkeys); 
     507    unsigned i; 
     508    for (i=0; i<sz_dsstests; i++) 
     509        { 
     510        char teststr[MAXBUF]; 
     511        const ops_keydata_t* keydata; 
     512        const ops_secret_key_t* skey; 
     513 
     514        snprintf(teststr,MAXBUF,"%s%d","test_dsa_signature_dss",i); 
     515        create_testdata(teststr,testdata,MAXBUF); 
     516        keydata=ops_keyring_find_key_by_userid(&sec_keyring,dsstests[i].userid); 
     517        skey=ops_get_secret_key_from_data(keydata); 
     518        test_dsa_signature_sign_memory(OPS_UNARMOURED,testdata,MAXBUF,skey); 
     519        } 
    506520    } 
    507521 
     
    551565            return 0; 
    552566     
     567    if (NULL == CU_add_test(suite, "DSS keys", test_dsa_signature_dss)) 
     568            return 0; 
     569     
    553570    /* 
    554571    if (NULL == CU_add_test(suite, "Tests to be implemented", test_todo)) 
  • openpgpsdk/trunk/tests/test_rsa_encrypt.c

    r620 r631  
    2222#include "CUnit/Basic.h" 
    2323  
     24#include <openpgpsdk/defs.h> 
    2425#include <openpgpsdk/types.h> 
    2526#include "openpgpsdk/keyring.h" 
     
    214215static void test_rsa_encrypt_noarmour_nopassphrase_singlekey(void) 
    215216    { 
    216     int armour=0; 
    217     test_rsa_encrypt(armour,filename_rsa_noarmour_nopassphrase_singlekey, alpha_pub_keydata); 
     217    test_rsa_encrypt(OPS_UNARMOURED,filename_rsa_noarmour_nopassphrase_singlekey, alpha_pub_keydata); 
    218218    } 
    219219 
    220220static void test_rsa_encrypt_noarmour_passphrase_singlekey(void) 
    221221    { 
    222     int armour=0; 
    223     test_rsa_encrypt(armour,filename_rsa_noarmour_passphrase_singlekey,bravo_pub_keydata); 
     222    test_rsa_encrypt(OPS_UNARMOURED,filename_rsa_noarmour_passphrase_singlekey,bravo_pub_keydata); 
    224223    } 
    225224 
    226225static void test_rsa_encrypt_armour_nopassphrase_singlekey(void) 
    227226    { 
    228     int armour=1; 
    229     test_rsa_encrypt(armour,filename_rsa_armour_nopassphrase_singlekey,alpha_pub_keydata); 
     227    test_rsa_encrypt(OPS_ARMOURED,filename_rsa_armour_nopassphrase_singlekey,alpha_pub_keydata); 
    230228    } 
    231229 
    232230static void test_rsa_encrypt_armour_passphrase_singlekey(void) 
    233231    { 
    234     int armour=1; 
    235     test_rsa_encrypt(armour,filename_rsa_armour_passphrase_singlekey,bravo_pub_keydata); 
     232    test_rsa_encrypt(OPS_ARMOURED,filename_rsa_armour_passphrase_singlekey,bravo_pub_keydata); 
    236233    } 
    237234 
    238235static void test_rsa_encrypt_large_noarmour_nopassphrase(void) 
    239236    { 
    240     int armour=0; 
    241     test_rsa_encrypt(armour,filename_rsa_large_noarmour_nopassphrase, alpha_pub_keydata); 
     237    test_rsa_encrypt(OPS_UNARMOURED,filename_rsa_large_noarmour_nopassphrase, alpha_pub_keydata); 
    242238    } 
    243239 
    244240static void test_rsa_encrypt_large_armour_nopassphrase(void) 
    245241    { 
    246     int armour=1; 
    247     test_rsa_encrypt(armour,filename_rsa_large_armour_nopassphrase, alpha_pub_keydata); 
     242    test_rsa_encrypt(OPS_ARMOURED,filename_rsa_large_armour_nopassphrase, alpha_pub_keydata); 
    248243    } 
    249244 
  • openpgpsdk/trunk/tests/test_rsa_keys.c

    r624 r631  
    2222#include "CUnit/Basic.h" 
    2323 
     24#include "openpgpsdk/defs.h" 
    2425#include "openpgpsdk/keyring.h" 
    2526#include "openpgpsdk/crypto.h" 
     
    193194static void test_rsa_keys_verify_keypair(void) 
    194195    { 
    195     ops_boolean_t armoured=ops_false; 
    196     verify_keypair(armoured); 
     196    verify_keypair(OPS_UNARMOURED); 
    197197    } 
    198198 
     
    200200    { 
    201201    ops_keyring_t keyring; 
    202     ops_boolean_t armoured=ops_false; 
    203202    char filename[MAXBUF+1]; 
    204203    snprintf(filename,MAXBUF,"%s/%s", dir, "pubring.gpg"); 
     
    206205    memset(&keyring, '\0', sizeof keyring); 
    207206 
    208     ops_keyring_read_from_file(&keyring, armoured, filename); 
     207    ops_keyring_read_from_file(&keyring, OPS_UNARMOURED, filename); 
    209208    ops_keyring_free(&keyring); 
    210209    } 
     
    212211static void test_rsa_keys_verify_armoured_keypair(void) 
    213212    { 
    214     ops_boolean_t armoured=ops_true; 
    215     verify_keypair(armoured); 
     213    verify_keypair(OPS_ARMOURED); 
    216214    } 
    217215 
     
    230228    char filename[MAXBUF+1]; 
    231229    int fd=0; 
    232     ops_boolean_t armour=ops_true; 
    233230    char* name1="First User<user1@nowhere.com>"; 
    234231    uid1.user_id=(unsigned char *)name1; 
     
    257254    snprintf(filename,MAXBUF,"%s/%s",dir,"transferable_public_key_1"); 
    258255    fd=ops_setup_file_write(&cinfo, filename,overwrite); 
    259     ops_write_transferable_public_key(keydata,armour,cinfo); 
    260     ops_teardown_file_write(cinfo,fd); 
    261     ops_keyring_read_from_file(&keyring1, armour, filename); 
     256    ops_write_transferable_public_key(keydata,OPS_ARMOURED,cinfo); 
     257    ops_teardown_file_write(cinfo,fd); 
     258    ops_keyring_read_from_file(&keyring1, OPS_ARMOURED, filename); 
    262259 
    263260    // Keyring 2 
     
    266263    snprintf(filename,MAXBUF,"%s/%s",dir,"transferable_public_key_2"); 
    267264    fd=ops_setup_file_write(&cinfo, filename,overwrite); 
    268     ops_write_transferable_public_key(keydata,armour,cinfo); 
    269     ops_teardown_file_write(cinfo,fd); 
    270     ops_keyring_read_from_file(&keyring2, armour, filename); 
     265    ops_write_transferable_public_key(keydata,OPS_ARMOURED,cinfo); 
     266    ops_teardown_file_write(cinfo,fd); 
     267    ops_keyring_read_from_file(&keyring2, OPS_ARMOURED, filename); 
    271268 
    272269    // Keyring 3 
     
    281278    snprintf(filename,MAXBUF,"%s/%s",dir,"transferable_public_key_3_bad"); 
    282279    fd=ops_setup_file_write(&cinfo, filename, overwrite); 
    283     ops_write_transferable_public_key(keydata,armour,cinfo); 
    284     ops_teardown_file_write(cinfo,fd); 
    285     ops_keyring_read_from_file(&keyring3, armour, filename); 
     280    ops_write_transferable_public_key(keydata,OPS_ARMOURED,cinfo); 
     281    ops_teardown_file_write(cinfo,fd); 
     282    ops_keyring_read_from_file(&keyring3, OPS_ARMOURED, filename); 
    286283 
    287284    /* 
  • openpgpsdk/trunk/tests/test_rsa_signature.c

    r625 r631  
    2222#include "CUnit/Basic.h" 
    2323 
     24#include <openpgpsdk/defs.h> 
    2425#include <openpgpsdk/types.h> 
    2526#include "openpgpsdk/keyring.h" 
     
    425426static void test_rsa_signature_large_noarmour_nopassphrase(void) 
    426427    { 
    427     int armour=0; 
    428     assert(pub_keyring.nkeys); 
    429     test_rsa_signature_sign(armour,filename_rsa_large_noarmour_nopassphrase, alpha_skey); 
     428    assert(pub_keyring.nkeys); 
     429    test_rsa_signature_sign(OPS_UNARMOURED,filename_rsa_large_noarmour_nopassphrase, alpha_skey); 
    430430    } 
    431431 
    432432static void test_rsa_signature_large_armour_nopassphrase(void) 
    433433    { 
    434     int armour=1; 
    435     assert(pub_keyring.nkeys); 
    436     test_rsa_signature_sign(armour,filename_rsa_large_armour_nopassphrase, alpha_skey); 
     434    assert(pub_keyring.nkeys); 
     435    test_rsa_signature_sign(OPS_ARMOURED,filename_rsa_large_armour_nopassphrase, alpha_skey); 
    437436    } 
    438437 
     
    440439    { 
    441440    unsigned char testdata[MAXBUF]; 
    442     int armour=0; 
    443     assert(pub_keyring.nkeys); 
    444     test_rsa_signature_sign(armour,filename_rsa_noarmour_nopassphrase, alpha_skey); 
     441    assert(pub_keyring.nkeys); 
     442    test_rsa_signature_sign(OPS_UNARMOURED,filename_rsa_noarmour_nopassphrase, alpha_skey); 
    445443    create_testdata("test_rsa_signature_noarmour_nopassphrase",testdata, MAXBUF); 
    446     test_rsa_signature_sign_memory(armour,testdata,MAXBUF, alpha_skey); 
     444    test_rsa_signature_sign_memory(OPS_UNARMOURED,testdata,MAXBUF, alpha_skey); 
    447445    } 
    448446 
     
    450448    { 
    451449    unsigned char testdata[MAXBUF]; 
    452     int armour=0; 
    453     assert(pub_keyring.nkeys); 
    454     test_rsa_signature_sign(armour,filename_rsa_noarmour_passphrase, bravo_skey); 
     450    assert(pub_keyring.nkeys); 
     451    test_rsa_signature_sign(OPS_ARMOURED,filename_rsa_noarmour_passphrase, bravo_skey); 
    455452 
    456453    create_testdata("test_rsa_signature_noarmour_passphrase",testdata, MAXBUF); 
    457     test_rsa_signature_sign_memory(armour,testdata,MAXBUF, bravo_skey); 
     454    test_rsa_signature_sign_memory(OPS_ARMOURED,testdata,MAXBUF, bravo_skey); 
    458455    } 
    459456 
     
    461458    { 
    462459    unsigned char testdata[MAXBUF]; 
    463     int armour=1; 
    464     assert(pub_keyring.nkeys); 
    465     test_rsa_signature_sign(armour,filename_rsa_armour_nopassphrase, alpha_skey); 
     460    assert(pub_keyring.nkeys); 
     461    test_rsa_signature_sign(OPS_ARMOURED,filename_rsa_armour_nopassphrase, alpha_skey); 
    466462 
    467463    create_testdata("test_rsa_signature_armour_nopassphrase",testdata, MAXBUF); 
    468     test_rsa_signature_sign_memory(armour,testdata,MAXBUF, alpha_skey); 
     464    test_rsa_signature_sign_memory(OPS_ARMOURED,testdata,MAXBUF, alpha_skey); 
    469465    } 
    470466 
     
    473469    unsigned char testdata[MAXBUF]; 
    474470 
    475     int armour=1; 
    476     assert(pub_keyring.nkeys); 
    477     test_rsa_signature_sign(armour,filename_rsa_armour_passphrase, bravo_skey); 
     471    assert(pub_keyring.nkeys); 
     472    test_rsa_signature_sign(OPS_ARMOURED,filename_rsa_armour_passphrase, bravo_skey); 
    478473 
    479474    create_testdata("test_rsa_signature_armour_passphrase",testdata, MAXBUF); 
    480     test_rsa_signature_sign_memory(armour,testdata,MAXBUF, bravo_skey); 
     475    test_rsa_signature_sign_memory(OPS_ARMOURED,testdata,MAXBUF, bravo_skey); 
    481476    } 
    482477 
  • openpgpsdk/trunk/tests/test_rsa_verify.c

    r627 r631  
    2222#include "CUnit/Basic.h" 
    2323 
     24#include <openpgpsdk/defs.h> 
    2425#include <openpgpsdk/types.h> 
    2526#include "openpgpsdk/keyring.h" 
     
    511512static void test_rsa_verify_v3sig(void) 
    512513    { 
    513     int armour=0; 
    514     assert(pub_keyring.nkeys); 
    515  
    516     test_rsa_verify_ok(armour,filename_rsa_v3sig); 
     514    assert(pub_keyring.nkeys); 
     515 
     516    test_rsa_verify_ok(OPS_UNARMOURED,filename_rsa_v3sig); 
    517517    } 
    518518 
    519519static void test_rsa_verify_hash_md5(void) 
    520520    { 
    521     int armour=0; 
    522     assert(pub_keyring.nkeys); 
    523  
    524     test_rsa_verify_ok(armour,filename_rsa_hash_md5); 
     521    assert(pub_keyring.nkeys); 
     522 
     523    test_rsa_verify_ok(OPS_UNARMOURED,filename_rsa_hash_md5); 
    525524    } 
    526525 
    527526static void test_rsa_verify_hash_sha256(void) 
    528527    { 
    529     int armour=0; 
    530     assert(pub_keyring.nkeys); 
    531  
    532     test_rsa_verify_ok(armour,filename_rsa_hash_sha256); 
     528    assert(pub_keyring.nkeys); 
     529 
     530    test_rsa_verify_ok(OPS_UNARMOURED,filename_rsa_hash_sha256); 
    533531    } 
    534532 
    535533static void test_rsa_verify_noarmour_nopassphrase(void) 
    536534    { 
    537     int armour=0; 
    538     assert(pub_keyring.nkeys); 
    539  
    540     test_rsa_verify_ok(armour,filename_rsa_noarmour_nopassphrase); 
     535    assert(pub_keyring.nkeys); 
     536 
     537    test_rsa_verify_ok(OPS_UNARMOURED,filename_rsa_noarmour_nopassphrase); 
    541538    } 
    542539 
    543540static void test_rsa_verify_noarmour_passphrase(void) 
    544541    { 
    545     int armour=0; 
    546     assert(pub_keyring.nkeys); 
    547     test_rsa_verify_ok(armour,filename_rsa_noarmour_passphrase); 
     542    assert(pub_keyring.nkeys); 
     543    test_rsa_verify_ok(OPS_UNARMOURED,filename_rsa_noarmour_passphrase); 
    548544    } 
    549545 
    550546static void test_rsa_verify_armour_nopassphrase(void) 
    551547    { 
    552     int armour=1; 
    553     assert(pub_keyring.nkeys); 
    554  
    555     test_rsa_verify_ok(armour,filename_rsa_armour_nopassphrase); 
     548    assert(pub_keyring.nkeys); 
     549 
     550    test_rsa_verify_ok(OPS_ARMOURED,filename_rsa_armour_nopassphrase); 
    556551    } 
    557552 
    558553static void test_rsa_verify_armour_passphrase(void) 
    559554    { 
    560     int armour=1; 
    561     assert(pub_keyring.nkeys); 
    562  
    563     test_rsa_verify_ok(armour,filename_rsa_armour_passphrase); 
     555    assert(pub_keyring.nkeys); 
     556 
     557    test_rsa_verify_ok(OPS_ARMOURED,filename_rsa_armour_passphrase); 
    564558    } 
    565559 
    566560static void test_rsa_verify_clearsign_nopassphrase(void) 
    567561    { 
    568     int armour=1; 
    569     assert(pub_keyring.nkeys); 
    570  
    571     test_rsa_verify_ok(armour,filename_rsa_clearsign_nopassphrase); 
     562    assert(pub_keyring.nkeys); 
     563 
     564    test_rsa_verify_ok(OPS_ARMOURED,filename_rsa_clearsign_nopassphrase); 
    572565    } 
    573566 
    574567static void test_rsa_verify_clearsign_passphrase(void) 
    575568    { 
    576     int armour=1; 
    577     assert(pub_keyring.nkeys); 
    578  
    579     test_rsa_verify_ok(armour,filename_rsa_clearsign_passphrase); 
     569    assert(pub_keyring.nkeys); 
     570 
     571    test_rsa_verify_ok(OPS_ARMOURED,filename_rsa_clearsign_passphrase); 
    580572    } 
    581573 
     
    629621static void test_rsa_verify_noarmour_fail_bad_sig(void) 
    630622    { 
    631     int armour=0; 
    632     assert(pub_keyring.nkeys); 
    633  
    634     test_rsa_verify_fail(armour,filename_rsa_noarmour_fail_bad_sig,callback_bad_sig,OPS_E_V_BAD_SIGNATURE); 
     623    assert(pub_keyring.nkeys); 
     624 
     625    test_rsa_verify_fail(OPS_UNARMOURED,filename_rsa_noarmour_fail_bad_sig,callback_bad_sig,OPS_E_V_BAD_SIGNATURE); 
    635626    } 
    636627 
    637628static void test_rsa_verify_v3sig_fail_bad_sig(void) 
    638629    { 
    639     int armour=0; 
    640     assert(pub_keyring.nkeys); 
    641  
    642     test_rsa_verify_fail(armour,filename_rsa_v3sig_fail_bad_sig, callback_bad_sig, OPS_E_V_BAD_SIGNATURE); 
     630    assert(pub_keyring.nkeys); 
     631 
     632    test_rsa_verify_fail(OPS_UNARMOURED,filename_rsa_v3sig_fail_bad_sig, callback_bad_sig, OPS_E_V_BAD_SIGNATURE); 
    643633    } 
    644634 
    645635static void test_rsa_verify_clearsign_fail_bad_sig(void) 
    646636    { 
    647     int armour=1; 
    648     assert(pub_keyring.nkeys); 
    649  
    650     test_rsa_verify_fail(armour,filename_rsa_clearsign_fail_bad_sig,callback_bad_sig,OPS_E_V_BAD_SIGNATURE); 
     637    assert(pub_keyring.nkeys); 
     638 
     639    test_rsa_verify_fail(OPS_ARMOURED,filename_rsa_clearsign_fail_bad_sig,callback_bad_sig,OPS_E_V_BAD_SIGNATURE); 
    651640    } 
    652641 
     
    654643    { 
    655644    int i=0; 
    656     int armour=1; 
    657645    assert(pub_keyring.nkeys); 
    658646 
     
    661649        char filename[MAXBUF]; 
    662650        make_filename_malformed(filename,MAXBUF,i); 
    663         test_rsa_verify_fail(armour,filename,NULL,OPS_E_R_BAD_FORMAT); 
     651        test_rsa_verify_fail(OPS_ARMOURED,filename,NULL,OPS_E_R_BAD_FORMAT); 
    664652        } 
    665653    } 
     
    668656    { 
    669657    int i=0; 
    670     int armour=1; 
    671658    assert(pub_keyring.nkeys); 
    672659 
     
    675662        char filename[MAXBUF]; 
    676663        make_filename_wellformed(filename,MAXBUF,i); 
    677         test_rsa_verify_wellformed(armour,filename,NULL); 
     664        test_rsa_verify_wellformed(OPS_ARMOURED,filename,NULL); 
    678665        } 
    679666    }