Changeset 594

Show
Ignore:
Timestamp:
08/22/08 14:24:47
Author:
rachel
Message:

Added test to check that userid and keyid are available from keys
in valid keyring after validation.
Fixed code which caused that test to fail.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • openpgpsdk/trunk/src/lib/validate.c

    r574 r594  
    111111 
    112112    // increase size of array 
    113     newsize=sizeof signer * result->valid_count; 
     113    newsize=(sizeof *signer) * result->valid_count; 
    114114    if (!result->valid_keys) 
    115115        result->valid_keys=malloc(newsize); 
     
    118118 
    119119    // copy key ptr to array 
    120     start=(sizeof signer) * (result->valid_count-1); 
    121     memcpy(result->valid_keys+start,signer,sizeof signer); 
     120    start=(sizeof *signer) * (result->valid_count-1); 
     121    memcpy(result->valid_keys+start,signer,sizeof *signer); 
    122122    } 
    123123 
     
    131131 
    132132    // increase size of array 
    133     newsize=sizeof signer * result->invalid_count; 
     133    newsize=(sizeof *signer) * result->invalid_count; 
    134134    if (!result->invalid_keys) 
    135135        result->invalid_keys=malloc(newsize); 
     
    138138 
    139139    // copy key ptr to array 
    140     start=(sizeof signer) * (result->invalid_count-1); 
    141     memcpy(result->invalid_keys+start,signer,sizeof signer); 
     140    start=(sizeof *signer) * (result->invalid_count-1); 
     141    memcpy(result->invalid_keys+start,signer,(sizeof *signer)); 
    142142    } 
    143143 
     
    151151 
    152152    // increase size of array 
    153     newsize=sizeof signer_id * result->unknown_signer_count; 
     153    newsize=(sizeof *signer_id) * result->unknown_signer_count; 
    154154    if (!result->unknown_keys) 
    155155        result->unknown_keys=malloc(newsize); 
  • openpgpsdk/trunk/tests/test_rsa_keys.c

    r573 r594  
    107107    int rtn=0; 
    108108    ops_boolean_t overwrite=ops_true; 
     109    char* userid="Test User 2<test2@nowhere.com>"; 
     110    const unsigned char* keyid; 
    109111 
    110112    memset(&pub_keyring, '\0', sizeof pub_keyring); 
    111113    memset(&sec_keyring, '\0', sizeof sec_keyring); 
    112114 
    113     uid.user_id=(unsigned char *)"Test User 2<test2@nowhere.com>"; 
     115 
     116    uid.user_id=(unsigned char *) userid; 
    114117 
    115118    keydata=ops_rsa_create_selfsigned_keypair(1024,65537,&uid); 
     119    CU_ASSERT(keydata != NULL); 
    116120    pub_key=ops_get_public_key_from_data(keydata); 
    117121    sec_key=ops_get_secret_key_from_data(keydata); 
    118  
    119     CU_ASSERT(keydata != NULL); 
     122    keyid=ops_get_key_id(keydata); 
    120123 
    121124    /* 
     
    141144    ops_validate_all_signatures(result, &pub_keyring, NULL); 
    142145    CU_ASSERT(result->valid_count==1); 
     146    CU_ASSERT(strncmp((char *)ops_get_key_id(&result->valid_keys[0]),(char *)keyid,strlen((char *)keyid))==0); 
     147    CU_ASSERT(strncmp((char *)ops_get_user_id(&result->valid_keys[0],0),userid,strlen(userid))==0); 
    143148    CU_ASSERT(result->invalid_count==0); 
    144149    CU_ASSERT(result->unknown_signer_count==0);