Changeset 368

Show
Ignore:
Timestamp:
02/19/06 15:35:42
Author:
ben
Message:

Constification, plus bugfix where strings were freed that might not have been
malloced.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • openpgpsdk/trunk/examples/packet-dump.c

    r367 r368  
    243243    } 
    244244 
    245 static void print_string_and_value( char *name, char *str, unsigned char value) 
     245static void print_string_and_value(char *name,const char *str, 
     246                                   unsigned char value) 
    246247    { 
    247248    print_name(name); 
     
    378379    const ops_parser_content_union_t *content=&content_->content; 
    379380    ops_text_t *text; 
    380     char *str; 
     381    const char *str; 
    381382    ops_key_data_t *decrypter; 
    382383    const ops_secret_key_t *secret; 
     
    759760                      &content->ss_revocation_reason.code, 
    760761                      1); 
    761         str = ops_show_ss_rr_code(content->ss_revocation_reason.code); 
     762        str=ops_show_ss_rr_code(content->ss_revocation_reason.code); 
    762763        print_string(NULL,str); 
    763764        /* xxx - todo : output text as UTF-8 string */ 
  • openpgpsdk/trunk/include/openpgpsdk/packet-show.h

    r367 r368  
    3737void ops_text_free(ops_text_t *text); 
    3838 
    39 char *ops_show_packet_tag(ops_packet_tag_t packet_tag); 
    40 char *ops_show_ss_type(ops_ss_type_t ss_type); 
     39const char *ops_show_packet_tag(ops_packet_tag_t packet_tag); 
     40const char *ops_show_ss_type(ops_ss_type_t ss_type); 
    4141 
    42 char *ops_show_sig_type(ops_sig_type_t sig_type); 
    43 char *ops_show_pka(ops_public_key_algorithm_t pka); 
     42const char *ops_show_sig_type(ops_sig_type_t sig_type); 
     43const char *ops_show_pka(ops_public_key_algorithm_t pka); 
    4444 
    4545ops_text_t *ops_showall_ss_preferred_compression(ops_ss_preferred_compression_t ss_preferred_compression); 
    46 char *ops_show_ss_preferred_compression(unsigned char octet); 
     46const char *ops_show_ss_preferred_compression(unsigned char octet); 
    4747 
    4848ops_text_t *ops_showall_ss_preferred_hash(ops_ss_preferred_hash_t ss_preferred_hash); 
    49 char *ops_show_hash_algorithm(unsigned char octet); 
    50 char *ops_show_symmetric_algorithm(unsigned char hash); 
     49const char *ops_show_hash_algorithm(unsigned char octet); 
     50const char *ops_show_symmetric_algorithm(unsigned char hash); 
    5151 
    5252ops_text_t *ops_showall_ss_preferred_ska(ops_ss_preferred_ska_t ss_preferred_ska); 
    53 char *ops_show_ss_preferred_ska(unsigned char octet); 
     53const char *ops_show_ss_preferred_ska(unsigned char octet); 
    5454 
    55 char *ops_show_ss_rr_code(ops_ss_rr_code_t ss_rr_code); 
     55const char *ops_show_ss_rr_code(ops_ss_rr_code_t ss_rr_code); 
    5656 
    5757ops_text_t *ops_showall_ss_features(ops_ss_features_t ss_features); 
    5858 
    5959ops_text_t *ops_showall_ss_key_flags(ops_ss_key_flags_t ss_key_flags); 
    60 char *ops_show_ss_key_flag(unsigned char octet, ops_bit_map_t *map); 
     60const char *ops_show_ss_key_flag(unsigned char octet, ops_bit_map_t *map); 
    6161 
    6262ops_text_t *ops_showall_ss_key_server_prefs(ops_ss_key_server_prefs_t ss_key_server_prefs); 
    63 char *ops_show_ss_key_server_prefs(unsigned char octet, ops_bit_map_t *map); 
     63const char *ops_show_ss_key_server_prefs(unsigned char octet, 
     64                                         ops_bit_map_t *map); 
    6465 
    6566ops_text_t *ops_showall_ss_notation_data_flags(ops_ss_notation_data_t ss_notation_data); 
  • openpgpsdk/trunk/src/packet-show.c

    r367 r368  
    251251    } 
    252252 
    253 static unsigned int add_str(ops_list_t *list, char *str) 
     253static unsigned int add_str(ops_list_t *list,char *str) 
    254254    { 
    255255    if (list->size==list->used)  
     
    311311 
    312312/*! generic function which adds text derived from single octet map to text */ 
    313 static unsigned int add_str_from_octet_map(ops_text_t *text, char *str, unsigned char octet) 
     313static unsigned int add_str_from_octet_map(ops_text_t *text,char *str, 
     314                                           unsigned char octet) 
    314315    { 
    315316    if (str && !add_str(&text->known,str))  
     
    367368 
    368369static ops_text_t *text_from_bytemapped_octets(ops_data_t *data,  
    369                                 char *(*text_fn)(unsigned char octet)) 
     370                                const char *(*text_fn)(unsigned char octet)) 
    370371    { 
    371372 
    372373    ops_text_t *text=NULL; 
    373     char *str; 
     374    const char *str; 
    374375    unsigned i; 
    375376 
     
    388389 
    389390        /*! and add to text */ 
    390         if (!add_str_from_octet_map(text,str,data->contents[i])) 
     391        if (!add_str_from_octet_map(text,strdup(str),data->contents[i])) 
    391392            { 
    392393            ops_text_free(text); 
     
    456457 * \return string or "Unknown" 
    457458*/ 
    458 char *ops_show_packet_tag(ops_packet_tag_t packet_tag) 
     459const char *ops_show_packet_tag(ops_packet_tag_t packet_tag) 
    459460    { 
    460461    return show_packet_tag(packet_tag,packet_tag_map); 
     
    468469 * \return string or "Unknown" 
    469470 */ 
    470 char *ops_show_ss_type(ops_ss_type_t ss_type) 
     471const char *ops_show_ss_type(ops_ss_type_t ss_type) 
    471472    { 
    472473    return show_ss_type(ss_type,ss_type_map); 
     
    481482 * \return string or "Unknown" 
    482483 */ 
    483 char *ops_show_ss_rr_code(ops_ss_rr_code_t ss_rr_code) 
     484const char *ops_show_ss_rr_code(ops_ss_rr_code_t ss_rr_code) 
    484485    { 
    485486    return show_ss_rr_code(ss_rr_code,ss_rr_code_map); 
     
    494495 * \return string or "Unknown" 
    495496 */ 
    496 char *ops_show_sig_type(ops_sig_type_t sig_type) 
     497const char *ops_show_sig_type(ops_sig_type_t sig_type) 
    497498    { 
    498499    return show_sig_type(sig_type, sig_type_map); 
     
    507508 * \return string or "Unknown" 
    508509 */ 
    509 char *ops_show_pka(ops_public_key_algorithm_t pka) 
     510const char *ops_show_pka(ops_public_key_algorithm_t pka) 
    510511    { 
    511512    return show_pka(pka, public_key_algorithm_map); 
     
    518519 * \return string or "Unknown" 
    519520*/ 
    520 char *ops_show_ss_preferred_compression(unsigned char octet) 
     521const char *ops_show_ss_preferred_compression(unsigned char octet) 
    521522    { 
    522523    return ops_str_from_map(octet,compression_algorithm_map); 
     
    548549 * \return string or "Unknown" 
    549550 */ 
    550 char *ops_show_hash_algorithm(unsigned char hash) 
     551const char *ops_show_hash_algorithm(unsigned char hash) 
    551552    { 
    552553    return show_hash_algorithm(hash); 
     
    568569    } 
    569570 
    570 char *ops_show_symmetric_algorithm(unsigned char hash) 
     571const char *ops_show_symmetric_algorithm(unsigned char hash) 
    571572    { 
    572573    return show_symmetric_algorithm(hash); 
     
    580581 * \return string or "Unknown" 
    581582*/ 
    582 char *ops_show_ss_preferred_ska(unsigned char octet) 
     583const char *ops_show_ss_preferred_ska(unsigned char octet) 
    583584    { 
    584585    return ops_str_from_map(octet,symmetric_algorithm_map); 
     
    666667 * \todo add reference 
    667668*/ 
    668 char *ops_show_ss_key_flag(unsigned char octet, ops_bit_map_t *map) 
     669const char *ops_show_ss_key_flag(unsigned char octet, ops_bit_map_t *map) 
    669670    { 
    670671    return str_from_bitfield(octet,map); 
     
    684685    { 
    685686    ops_text_t *text=NULL; 
    686     char *str; 
     687    const char *str; 
    687688    int i=0; 
    688689    unsigned char mask, bit; 
    689690 
    690     text=malloc(sizeof(ops_text_t)); 
     691    text=malloc(sizeof(ops_text_t)); 
    691692    if (!text) 
    692693        return NULL; 
     
    696697    /* xxx - TBD: extend to handle multiple octets of bits - rachel */ 
    697698 
    698     for (i=0, mask=0x80; i<8; i++, mask = mask>>1
     699    for (i=0,mask=0x80 ; i < 8 ; i++,mask=mask >> 1
    699700            { 
    700             bit = ss_key_flags.data.contents[0] & mask; 
    701             if (bit) 
     701            bit=ss_key_flags.data.contents[0]&mask; 
     702            if(bit) 
    702703                { 
    703                 str=ops_show_ss_key_flag ( bit, &ss_key_flags_map[0] ); 
    704                 if (!add_str_from_bit_map( text, str, bit)) 
     704                str=ops_show_ss_key_flag(bit,&ss_key_flags_map[0]); 
     705                if(!add_str_from_bit_map(text,strdup(str),bit)) 
    705706                    { 
    706707                    ops_text_free(text); 
     
    724725 * \todo make typesafe 
    725726 */ 
    726 char *ops_show_ss_key_server_prefs(unsigned char prefs, ops_bit_map_t *map) 
     727const char *ops_show_ss_key_server_prefs(unsigned char prefs, 
     728                                         ops_bit_map_t *map) 
    727729    { 
    728730    return str_from_bitfield(prefs,map); 
     
    742744    { 
    743745    ops_text_t *text=NULL; 
    744     char *str; 
     746    const char *str; 
    745747    int i=0; 
    746748    unsigned char mask, bit; 
     
    754756    /* xxx - TBD: extend to handle multiple octets of bits - rachel */ 
    755757 
    756     for (i=0, mask=0x80; i<8; i++, mask = mask>>1
     758    for (i=0,mask=0x80 ; i < 8 ; i++,mask=mask >> 1
    757759            { 
    758             bit = ss_key_server_prefs.data.contents[0] & mask; 
     760            bit=ss_key_server_prefs.data.contents[0]&mask; 
    759761            if (bit) 
    760762                { 
    761                 str=ops_show_ss_key_server_prefs ( bit, &ss_key_server_prefs_map[0] ); 
    762                 if (!add_str_from_bit_map( text, str, bit)) 
     763                str=ops_show_ss_key_server_prefs(bit, 
     764                                                 &ss_key_server_prefs_map[0]); 
     765                if(!add_str_from_bit_map( text, strdup(str), bit)) 
    763766                    { 
    764767                    ops_text_free(text);