Changeset 246

Timestamp:

10/24/05 16:02:19

Author:

ben

Message:

Values may not have been initialised. Also, where available, fill in signature
creation time.

Files:

• openpgpsdk/trunk/examples/packet-dump.c (modified) (2 diffs)
• openpgpsdk/trunk/include/openpgpsdk/packet.h (modified) (2 diffs)
• openpgpsdk/trunk/src/packet-parse.c (modified) (4 diffs)

openpgpsdk/trunk/examples/packet-dump.c

@@ -707 +707 @@
-        print_unsigned_int("Signature Version",
-               content->signature.version);
-version == 3
+creation_time_set
-            print_time("Signature Creation Time", content->signature.creation_time);
-
@@ -714 +714 @@
-                               content->signature.type);
-
-
-
-
+
+
+
+
-
-        print_string_and_value("Public Key Algorithm",

openpgpsdk/trunk/include/openpgpsdk/packet.h

@@ -491 +491 @@
-    ops_sig_version_t           version;        /*!< signature version number */
-    ops_sig_type_t              type;           /*!< signature type value */
-- only with v3 signatures
+
-    unsigned char               signer_id[OPS_KEY_ID_SIZE];     /*!< Eight-octet key ID of signer*/
-    ops_public_key_algorithm_t  key_algorithm;  /*!< public key algorithm number */
@@ -499 +499 @@
-    size_t                      v4_hashed_data_start; // only valid if accumulate is set
-    size_t                      v4_hashed_data_length;
+    ops_boolean_t               creation_time_set:1;
+    ops_boolean_t               signer_id_set:1;
-    } ops_signature_t;
-

openpgpsdk/trunk/src/packet-parse.c

@@ -999 +999 @@
-    if(!limited_read_time(&C.signature.creation_time,region,opt))
-        return 0;
-
-
-
+
+
+
+
+
-
-    if(!ops_limited_read(c,1,region,opt))
@@ -1109 +1111 @@
-        if(!limited_read_time(&C.ss_time.time,&subregion,opt))
-            return 0;
+        if(content.tag == OPS_PTAG_SS_CREATION_TIME)
+            {
+            sig->creation_time=C.ss_time.time;
+            sig->creation_time_set=ops_true;
+            }
-        break;
-
@@ -1128 +1135 @@
-            return 0;
-        memcpy(sig->signer_id,C.ss_issuer_key_id.key_id,OPS_KEY_ID_SIZE);
+        sig->signer_id_set=ops_true;
-        break;
-
@@ -1408 +1416 @@
-    ops_parser_content_t content;
-
+    memset(&C.signature,'\0',sizeof C.signature);
-    C.signature.version=OPS_SIG_V4;
-    C.signature.v4_hashed_data_start=v4_hashed_data_start;